Skip to content

[Accessibility]: extension actions on search page should be buttons

Created by: tjkandala

Audit type

General/Other

User journey audit issue

#34054 (closed)

Problem description

On the search page with the search-export extension enabled, the action contributed by search-export is rendered as <a> and not <button>, despite not causing page navigation on click.

Expected behavior

Search page extension actions should be <buttons> and look like the built-in actions.

Additional details

Screen Shot 2022-06-07 at 5 15 42 PM

The styling difference affects usability on mobile too:

Screen Shot 2022-06-07 at 5 19 39 PM

Button styling would increase the size of the touch target.

Assigning labels

  • Please give this issue an estimate by applying a label like estimate/Xd, where X is the estimated number of days it will take to complete.
  • If this issue is specific to a specific Sourcegraph product, please assign the appropriate team label to this issue.
  • If this issue will require input from designers in order to complete, please assign the label needs-design.
  • If you are confident that this issue should be fixed by GitStart, please assign the label gitstart.

Owner

This issue will be fixed by my team, I have assigned a relevant member to it, or I will do so in the near future.