Skip to content

[Accessibility]: No notification of error or success after adding or removing code host credentials

Created by: courier-new

Audit type

Screen reader navigation

User journey audit issue

https://github.com/sourcegraph/sourcegraph/issues/34073

Problem description

When I am adding my PAT for a code host and I click "Add credential" from the modal, it is not clear whether the operation succeeds or fails.

Expected behavior

If the operation fails, the error should be focused and dictated by the screen reader.

If the operation succeeds, there should be some sort of visual alert and indication of a status change. We could make use of the aria-live attribute to support this on the screen reader.

On successfully adding credentials, the screen reader should probably dictate "Credentials successfully configured for ". On successfully removing credentials, the screen reader should probably dictate "Credentials successfully removed for ".

Additional details

No response

Assigning labels

  • Please give this issue an estimate by applying a label like estimate/Xd, where X is the estimated number of days it will take to complete.
  • If this issue is specific to a specific Sourcegraph product, please assign the appropriate team label to this issue.
  • If this issue will require input from designers in order to complete, please assign the label needs-design.

Owner

This issue will be fixed by my team, I have assigned a relevant member to it, or I will do so in the near future.