Skip to content

Design Debt: unify styles of delete buttons and delete menu items

Created by: AlicjaSuska

Details

Throughout Sourcegraph app there are major inconsistencies in styles of delete actions - both (danger) buttons and contextual item menus.

Examples: insights: Screenshot 2022-04-19 at 13 16 54 monitors: Screenshot 2022-04-19 at 13 15 25 contexts: Screenshot 2022-04-19 at 13 14 30 notebooks: Screenshot 2022-04-19 at 13 13 59

Type of debt

  • Visual - focused on inconsistent graphical aspects of the interface like shapes, colors, etc.

Estimated amount of work

  • XS - 1 day

Areas affected

Buttons

  • Code Insights: 'delete' insight in editing UI
  • Contexts: 'delete' context in editing UI
  • Monitoring: 'delete' monitor in editing UI

Contextual menus

  • Code Insights: 'delete insight' in insight card, 'delete dashboard' in dashboard menu
  • Notebooks: 'delete' notebook

Impact

  • consistency - direct impact on customers
  • visual consistency - how our product is perceived
  • reducing the possibility of producing future debt - impact on teams

Urgency

Not critical but quite urgent as we'd be producing more debt over time without addressing this issue.

Action plan:

  • All designers review their respective areas of the product and gather them in the Figma file by Apr 22
  • All designers to review the proposed solution (red context menu item and danger outline button) and apply it to their respective examples in the same Figma file by Apr 27
  • All designers to create sub-issues and bring it up with their respective teams by Apr 29
  • Incorporate the corrections in the next 1-2 iterations so that we can close this issue by May 20
  • Create documentation in Figma (may be part of the breaders)