Skip to content

Incorrect use of url argument in browser extension eventlogger

Created by: dadlerj

The url argument to telemetryservice/eventlogger calls should represent the current URL in which the event occurs. For telemetryservices/eventloggers running in the webapp, for example, it's whatever the window.location.host is when the event fires.

I was browsing the bext eventlogger code just now, and I noticed that we seem to be passing the sourcegraphURL in for this argument, which represents something different (I think). My impression is that the sourcegraphURL value represents the URL of the Sourcegraph instance that the bext is connected to at that moment in time.

For event logs from the bext, I think it's appropriate to send null or an empty string for the url argument to eventlogger (instead of the actual github/code host URL).