Skip to content

LSIF Typed: should we rename `Suffix.Package` into `Suffix.Namespace` or something else?

Created by: olafurpg

Following up from this PR comment from @varungandhi-src https://github.com/sourcegraph/lsif-typescript/pull/1#discussion_r797577320 LSIF Typed uses the name "package" to refer to namespaces or modules. The name "package" origins from the JVM and it might be mis-understood outside the JVM. The lsif-typescript implementation also uses packages for source files, which is conceptually different from packages that it might make sense to use different suffixes.

Any suggestions? The relevant code is here https://github.com/sourcegraph/sourcegraph/blob/74cf2ef02b3f17f5979ecba6dbd834b4025f4509/proto/lib/codeintel/lsiftyped/lsif.proto#L123-L133

PS. I don't really like the name "Suffix" either, I'm open for alternative suggestions. I like the name "Kind" so that we can talk about descriptor kinds.