Fuzzy finder: Pressing Escape does not hide the modal in Firefox with Vimium extension installed

Created by: olafurpg

• Sourcegraph version: sourcegraph.com today
• Platform information: Firefox 94.0.2 (64-bit), macOS, Vimium extension

Steps to reproduce:

1. Activate fuzzy finder
2. Press escape, unfocuses the input
3. Press escape again, nothing happens

Expected behavior:

The modal should disappear in step 2, which is the behavior with Google Chrome.

Actual behavior:

Nothing happens in step 3. I can only reproduce in Firefox.

Possible solution

For consistency with the GitHub Command Palette, maybe we should only use Cmd+K as the keyboard shortcut to hide the modal. The Escape key is overloaded with lots of built-in behavior from the browser.