Erroneous user repositories empty state
Created by: sqs
Repro (on https://sourcegraph.com):
- Add a user code host connection to GitLab
- In the user repositories screen, select
GitLab
from theCode host:
filter. I also typedsqs/web
(the name of my repo on GitLab) into the top right query input. I was taken to the following URL: https://sourcegraph.com/users/sqs/settings/repositories?query=sqs%2Fweb&code-host=RXh0ZXJuYWxTZXJ2aWNlOjIyNDI%3D.
I saw the following screen:
This is unexpected because:
- I have added repos from GitHub that were already synced, so the message is not true.
- I also just intended to add GitLab repos, and I understand they're not synced yet, but the message makes it sound like it has finished loading and didn't find anything.
- It hides the filters (
Status:
/Code host:
) that were just visible.
Also, one other issue came up: after authing via GitLab, it didn't redirect me to a "Manage repositories" screen where I could select which GitLab repositories to sync. Should it have? It did for GitHub.