Skip to content

Confusion when searching for literal

Created by: sqs

From @JoshuaKGoldberg:

Trying a basic literal search for connect pure false and also getting zero results. See image below. Amusingly, it both says there are no results and that I've hit the result count limit.

Sourcegraph No Results Limit

My comments:

  • I can't reproduce the issue where the Result limit hit. alert shows up. I just see No results. But the screenshot proves it, so we should look into it.
  • In this case, the user wanted something like regexp connect.*pure.*false and (understandably but mistakenly) thought that our literal search would yield that. (That is what you'd get if you clicked the .* icon to enable regexp search.) How can we address this confusion? If I enable regexp search, I do see results. (Note that the higher-level intent was described in https://twitter.com/acemarke/status/1416585511565725696. The user really wanted something even simpler/higher-level, and we should absolutely make that work; see #22975. But we should also clear up this intermediate confusion.)

Related PR: #20356