Skip to content

Gerrit code host support doesn't get base and head patchsets correctly

Created by: marekweb

The Gerrit code host implementation makes two incorrect assumptions when a page displays a diff:

  • if the patchset ID is not specific in the URL path, then the patchset ID is 1. In reality, if the patchset is not specified then the most recent patchset is shown, which is not necessarily 1.
  • the parent of a diff of a patchset is the base. In reality, the parent can be selected with a dropdown, and can be the base or it can be any other previous patchset.

Instead of relying on the URL path to determine the patchset and the base, it needs to be determined based on the state of the base and patchset selector dropdowns that are on the page.