Patch release: Fix SAML validation error
Created by: unknwon
@sourcegraph/distribution I am requesting the following commits be included in a patch release. They are already merged into main:
The intent of the questions below is to ensure we keep Sourcegraph high quality and only create patch releases based on a strict criteria. If you can answer yes to many or most of these questions, we will be happy to create the patch release.
I have read when and why we perform patch releases and answer the questions as follows:
Are users/customers actively asking us for these changes and cannot wait until the next full release?
It's currently blocking a deal, https://github.com/sourcegraph/customer/issues/187
Are the changes extremely minimal, well-tested, and low risk such that not testing as we do in a full release is OK?
Yes, single dependency upgrade with a well-scoped fix to the problem that customer encountered.
Is there some functionality completely broken that warrants redacting the prior release of Sourcegraph and advising users wait for the patch release?
No, this is very edge case and shouldn't affect most of our customers/users.
This will interrupt our regular planned work and release cycle, taking 3-6 hours of our time, and will take up all of our site admin's valuable time by asking them to upgrade or producing noise for them if they don't need to upgrade.
Do you believe the changes are important enough to warrant this?
Yes
Patch releases are a signal we can do something better to improve the quality of Sourcegraph. Have you already scheduled a call (or created a google doc) to perform a retrospective and identify ways we can improve?
Yes
For the release captain - after reviewing and approving this request:
- If there is already an upcoming patch release, add the listed commits alongside a link to this issue
- If there is no upcoming patch release, create a new one:
- Update
dev/release/release-config.jsoncwith the patch release inupcomingReleaseandreleaseDate(and open a PR tomainto update it) yarn release tracking:issues- Add the listed commits alongside a link to this issue to the generated release tracking issue
- Update
Comment and close this issue once the relevant commit(s) have been cherry-picked into the release branch.