Skip to content

Batch Changes support for Gerrit Code Review

Created by: eseliger

Solution

Tasks likely involved:

  • Validate the Gerrit model makes sense with campaigns (it seems like but I never used it so it might be that campaigns is not suitable here). Also: gerrit seems to have tons of "untyped" properties to be added to changes, so there is potentially some manual work for users involved rather than just opening and then Gerrit ought to do everything for you (like GitHub for example) ?d
  • Add Gerrit source (We don't have first-class Gerrit support as of now, so need to add it to sourcer,...) 2d
  • Potentially fix https://github.com/sourcegraph/sourcegraph/issues/10117 1d
  • Make sure gitserver can push to refs/changes/XX (and potentially rework branch fields in the codebase, since we assume to always have refs/heads prefixes 1-4d
  • Configure our Gerrit test instance at https://gerrit.sgdev.org/ so it's usable for dev (if there is anything to do) 0.5d
  • Add gerrit to the list of supported code hosts <0.5d
  • Implement ChangesetSource methods on GerritSource 3d
  • Add logic to convert messages by tag to changeset events, use in state logic, .. 2d
  • Add integration tests 3d
  • Add webhooks support 3d
  • Add docs 1d

Impacted customers