Skip to content

Submodules are resolved into incorrect URL

Created by: christinelovett

Sourcegraph version 3.21.2

When browsing submodules under a meta-repo - users can view the main/trunk meta-repo, the commit dropdown lists an accurate history of commits. When the user clicks on a given commit, nothing happens. Meta-repo has submodules, the submodules are searchable directly but not when navigating through the meta-repo. The desired behavior is access the meta-repo, search at a universe hash, and see the submodules and their corresponding commits.

Our typical handling of submodules is, if we detect them, and we have the submodule repo itself synced, we simply list them in the file tree with a custom icon, and clicking on that entry takes the user to the submodule on Sourcegraph [https://sourcegraph.com/github.com/ezEngine/submodule-example]

The user sees the submodule in the file tree, with a valid commit hash, but clicking on it doesn’t do anything. The URL doesn’t change, the page doesn’t change, etc..

One hint: the user is using several repo name transformations in their GitLab connection config (e.g. to remove a .d-git from the end of repo names), which appear to not be respected by the submodule link in the file tree when the user hovers over it. Perhaps a place to check to start?

We can gather debug info if needed.

Customer: https://app.hubspot.com/contacts/2762526/company/578600789