Skip to content

Campaign patches with binaries don't apply

Created by: eseliger

  • Sourcegraph version: master
  • Platform information: macOS 10.15.4, Chrome 81

Steps to reproduce:

  1. Create an action that touches a binary file (ie. compress images in docs/ folder)
  2. Create campaign

Expected behavior:

It

  • works
  • or warned me that it can't work
  • or skips binaries so it doesn't fail

Actual behavior:

It fails with errors like

creating commit from patch for repository "X": gitserver: applying patch: exit status 1

$ git apply --cached -p0 --unidiff-zero
error: cannot apply binary patch to 'binary.ttf' without full index line
error: binary.ttf: patch does not apply

Corresponding diff (see that binary content is not inlined):

diff --git binary.ttf binary.ttf
index 563872c..3d12770 100644
Binary files binary.ttf and binary.ttf differ