Trying to publish a failed changeset again is noop
Created by: eseliger
- Sourcegraph version: master
- Platform information: macOS 10.15.4, Chrome 81
Steps to reproduce:
- Have a draft campaign (publishing needs to fail to repro, try no privilege token or so)
- Click publish on one single changeset
- It should fail, check the error messages in the campaign status
- Click publish on the changeset again
- See the spinner indicate something would happen
Expected behavior:
- It is tried again
Actual behavior:
- It only spins, no actual retry attempt is made. This piece of code just returns when a job exists (even if failed) https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/enterprise/internal/campaigns/service.go#L428-431