repo-updater: ExternalServiceSync does not block and only validates edited ExternalService (!4637) · Merge requests · Administrator / sourcegraph

Administrator requested to merge core/async-ext-sync into master Jun 21, 2019

Created by: keegancsmith

We now only validate the service that is edited can list repositories. Additionally we do not block if this takes longer than 10s. Previously we could run concurrent Syncs and cancel syncs based on the request context. Now we trigger a sync in a way were it won't conflict with Syncer.Run.

This PR paves the way for Syncer to report a status indicator.

Test plan: unit and testing manually by editing external services.

Fixes https://github.com/sourcegraph/sourcegraph/issues/4511

repo-updater: ExternalServiceSync does not block and only validates edited ExternalService

Merge request reports