Skip to content

JetBrains UI fixes

Administrator requested to merge dv/jetbrains-ui-fixes into main

Created by: vdavid

Fixes https://github.com/sourcegraph/sourcegraph/issues/38390 Also contributes to Icebox item https://github.com/sourcegraph/sourcegraph/issues/37688

  • Using the right IDE color for the result list background color and search box background color (a a lighter gray for dark themes)
  • Set selection background color to a blue that matches the IDE color (see caveats)
  • Increased column info font size : 10px→13px
  • Very slightly decreased column info horizontal padding
  • Made search result info color dynamic (it was hard-coded and a "TODO" was in the code)
  • Faded secondary info (item no. 3 in https://github.com/sourcegraph/sourcegraph/issues/37688)
  • Made the search box button hover colors match the IDE color (see caveats)
  • Made the search box button hover tooltip background and foreground color match the IDE colors (see caveats)
  • Removed "copy query" button (It added little value, and the shortcut written on it never worked.)

Caveats:

  • Selection doesn't disappear when the preview is selected (see video)
  • Button hover colors are probably not 100% the same as the native IDE hover colors, not sure why but it's much better than it was. (see video)
  • Tooltips don't have a border and I've found no easy way to add one. (see video)

Test plan

  • All changes demoed for both the dark and light themes in this 5-min Loom

App preview:

Check out the client app preview documentation to learn more.

Merge request reports

Loading