Skip to content

Code Insights: Connect UI and compute insight, assemble creation UI page

Administrator requested to merge vk/connect-ui-and-compute-insight-mutation-part-2 into main

Created by: vovakulikov

Based on https://github.com/sourcegraph/sourcegraph/pull/38739 Blocked (live preview component) by https://github.com/sourcegraph/sourcegraph/pull/38125 Closes https://github.com/sourcegraph/sourcegraph/issues/37965

Background

Screenshot 2022-07-14 at 17 49 40

This PR integrates live preview and creation form components. A few things to notice

  • Compute-powered insight creation UI has old designs (like all other creation forms at the moment). FYI @AlicjaSuska all redesign work won't be included in the first version of compute insight track and will be addressed later in this issue
  • Live preview doesn't have a timeframe field. It turned out this isn't so trivial to implement. Because our after/before filters may have different (sometimes complex to parse) values for example, after:"6 months ago". Taking into account our deadline for the first version I suggest moving this out for the second iteration over compute insight.
  • Series don't have colour picker and we don't colour bar in series colour, see this issue https://github.com/sourcegraph/sourcegraph/issues/38832 for more details

Todo

  • Add actions UI to the compute creation UI page
  • Update GQL API class createInsight method with compute powered insight
  • Rebase the main and integrate live preview component
  • Testing creation UI locally and with k8s

Test plan

  • Go to the /insights/create/group-results URL.
  • Make sure that you can create a compute-powered insight through the newly created compute creation UI page and see a correct live preview result.

App preview:

Check out the client app preview documentation to learn more.

Merge request reports