search: remove mutation on generated lucky query notifications
Created by: rvantonder
Stacked on https://github.com/sourcegraph/sourcegraph/pull/38355
This separates static vs dynamic concerns when constructing notifications, so there's no longer mutation on values.
Test plan
Updated tests