dev/sg: fix diff output in Buildkite without using Buildkite condition
Created by: bobheadxi
Closes https://github.com/sourcegraph/sourcegraph/issues/35918 , reverts https://github.com/sourcegraph/sourcegraph/pull/36043
The root cause seems to be termenv.IsDarkBackground()
hanging indefinitely in Buildkite. To work around this:
- Add
ForceDarkBackground
output option, set totrue
in Buildkite - Refactor output capabilities detection to be lazy (if an override is set, do not do any detection at all)
- Change most usages of
output.NewOutput
tostd.NewOutput
for consistency and to avoid the problematic dark background detection
Test plan
See test failure: https://buildkite.com/sourcegraph/sourcegraph/builds/150395#_