Skip to content

Webapp: Index tabs and tab panels for the panel blob component

Administrator requested to merge vk/attempt-to-fix-panal-tab into main

Created by: vovakulikov

History of merging changes

  • The first initial PR with updating reach-ui packages got merged https://github.com/sourcegraph/sourcegraph/pull/30845
  • Then it turned out that those components with new versions broke one of e2e tests (reference panel tabs)
  • Revert versions updating PR 4a84d8350301991fd7cf4a62790d1f530df73205
  • Create this PR with bringing back version updates and fix for the reference Panel tabs UI

Context

After this PR https://github.com/sourcegraph/sourcegraph/pull/30845 we got a new version of @reach-ui/tab components. In the latest version you have to pass an index value for the controlled mode of the Tab component otherwise Tab component doesn't match your Tab and TabPanel properly.

This PR updates Panel tabs accordingly and fixes panel tab logic.

Changes in this PR

  • Updating reach-ui components
  • Pin tslib versions in order to avoid tslib duplicates in the bundles
  • Bring a new tool for bundle analyzing statoscope
  • Fix problem with tab components at the reference Panel UI

Merging plan

Since this PR updates a lot of components in a transitive way (update low lever components versions) I would hold this one at least for the 3.37 release cut that will happen next week on Friday. After that, we will merge this into the main (it didn't get anything on review) and we will monitor whether there are any new problems with wildcard and any other shared components.

Merge request reports