Skip to content

Add seperate types for settings vs graphql dashboard

Administrator requested to merge jdb/graphql-dashboard-types into code-insights/gql-api-integration-branch

Created by: unclejustin

I'm thinking that it makes more sense to create a new interface for the GraphQL API structure. There are enough differences that we will not want to keep these references in the UI.

For example, builtIn, owner, and settingsKey will all no longer be needed.

I think we would be better off using the new interface and a union type for all of the API calls. This will get a little messy at first because we will have to cover all of the missing properties, but I think it will be much better in the long run.

The plan

  1. Merge this PR to update dashboard types
  2. PR to update insight types
  3. PR to union those types and fix the problems (this one will be big 😳 )
  4. Finally start updating the graphql API 😓

Merge request reports