Skip to content

Code Insights: Use reach ui popover instead of uncontrolled reactstrap popover component for the drill-down panel

Administrator requested to merge code-insights/drill-down-filters-popup into main

Created by: vovakulikov

Closes https://github.com/sourcegraph/sourcegraph/issues/23678

Context

This PR replaces the outdated popover component (reactstrap package) for code insights drill-down filter panel with a new approach with reach UI popover. Also as you can see on the gif below this PR introduce a new position calculation for the drill-down filter panel.

https://user-images.githubusercontent.com/18492575/128613413-631cb390-4bb7-42c2-ac45-9576b50b6d36.mov

Also in this PR card with opened filters panel has an active outline visual state

image

What have been done

  • Implement popover component based on reach UI popover
  • Add a storybook story for the grid component
  • Implement a custom calculator for the drill-down filter panel component

Merge request reports