Skip to content

Prevent empty settings from being stored

Administrator requested to merge prevent-empty-settings into master

Created by: chrismwendt

The empty string is valid jsonx (validated by https://github.com/sourcegraph/jsonx), but not valid jsonc. Consumers of settings using either of these jsonc-parser packages produce undefined when parsing the empty string:

This change prevents the empty string from being stored as settings.

image

Merge request reports

Loading