Skip to content

Implement RFC 221 changes to ViewOnSourcegraphButton

Administrator requested to merge tj/refactor-view-on-sg into main

Created by: tjkandala

Resolves https://github.com/sourcegraph/security-issues/issues/81 Resolves #3669 Resolves #14225 (1 change/issue tackled per commit)

Private github.com repositories issue

Update selectors for repoHeaderHasPrivateMarker check.

Always open Sourcegraph in new tab

target and rel are set to _blank and noopener norefferer by default respectively.

Improve 'Configure on Sourcegraph' flow

1 ) Only apply filter: grayscale(100%) to SourcegraphIconButton for "real" errors, not for private repository errors. 2) Chrome does not implement openPopup for security reasons, so we can't implement this change. (edit: Implementing in separate PR for working browsers)

Merge request reports