Skip to content

insights: sort or limit changes can cause deselected series to disappear and remain deselected

Created by: coury-clark

It is currently possible to end up in a dead state chart between the interactions of selecting / deselecting series for view, and sort / limit. This occurs because we do not reset the select / deselect state on sort / limit change, which means its possible for all of the limited series to be removed from the legend. A naive implementation might be to reset the select / deselect state when any sort or limit change occurs, but this will likely run into UX issues where a limited number of series are selected for view intentionally, and sorting may be desirable. An alternative might be to track if any deactivated series is ever removed from the legend, to reactivate it.

As a note, it's also possible this is just another manifestation of https://github.com/sourcegraph/sourcegraph/issues/36461 and will be fixed with the same problem, depending on implementation.

CleanShot 2022-06-02 at 10 27 56