Database URI in Migrator Logs
Created by: benjaminwgordon
- Sourcegraph version: 3.37.0
Steps to reproduce:
Expected behavior:
- Database URI in error message omits or encrypts password
Actual behavior:
- Database URI in error message contains external database connection password
migrator | error: frontend and codeintel databases must be distinct: postgres://sg:Fake_Password@Fake_Host:5432/sg?sslmode=disable and postgres://sg:Fake_Password@Fake_Host:5432/sg?sslmode=disable seem to refer to the same database
Omitting this password would be beneficial for users who would like to export their logs to an external service, to prevent sending unencrypted passwords.
https://sourcegraph.slack.com/archives/C1JH2BEHZ/p1646082479464059