Skip to content

insights: pings are reporting insight ID as insight type

Created by: coury-clark

For transparency here is the PR about fixing pings names https://github.com/sourcegraph/sourcegraph/pull/27891

I checked https://k8s.sgdev.org/site-admin/pings page and I couldn't manage to see increasing of WeeklyInsightCreators but I saw increasing of Additional for "InsightType": "searchInsights" and "InsightType": "codeStatsInsights".

{
                "Edits": 0,
                "Hovers": 1,
                "Removals": 0,
                "Additions": 2,
                "InsightType": "codeStatsInsights",
                "DataPointClicks": 0,
                "UICustomizations": 0
            },
            {
                "Edits": 0,
                "Hovers": 92,
                "Removals": 1,
                "Additions": 2,
                "InsightType": "searchInsights",
                "DataPointClicks": 0,
                "UICustomizations": 63
            }

@coury-clark other insights look like have a wrong type? not sure

Like, this is insight in the pings section. I suspect that we use insight id here as InsightType

  {
                "Edits": 0,
                "Hovers": 1,
                "Removals": 0,
                "Additions": 0,
                "InsightType": "aW5zaWdodF92aWV3OiJzZWFyY2hJbnNpZ2h0cy5pbnNpZ2h0LndpbGRjYXJkR3Jvd3RoIg==",
                "DataPointClicks": 0,
                "UICustomizations": 0
            },

Originally posted by @vovakulikov in https://github.com/sourcegraph/sourcegraph/pull/27741#discussion_r751992503