Tab adjustments for redesign
Created by: quinnkeast
Related to #20371 (closed) and #20526—creating a new issue for easily visibility.
The tabs are looking great! I have a few design adjustments:
-
There should be no visible padding on the left and right sides of the tabs. I say no visible, because the offset focus highlight extends past the indicator, so it may need a bit of trickery to pull it off. The padding around the text and the focus indicator will also need to adjust. To compare:
-
If possible, I'd like to find a way to handle the spacing/padding/sizing/etc. so that when a tab is selected or deselected, there's no visible "shift" other than that single tab's font weight changing, from the centre axis. This is less of an issue on the file sidebar and more of an issue on the popovers. -
There's an active state visible when the tab is pressed in light mode, which I don't think we need. It becomes a challenge when we have a delay before showing content, because it remains visible until the content loads, which looks sluggish.
https://user-images.githubusercontent.com/6304497/118806234-1b2e4b00-b8a7-11eb-95b2-7ad00d98d73a.mp4
Will add another issues I find here later.